feat: Tooltips in collection components #7289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/react-aria-components/src/Tooltip.tsx
snowystinger
changed the title
snowystinger
commented
Jan 21, 2025
| @@ -176,9 +177,16 @@ export function createLeafComponent<P extends object, E extends Element>(type: s | |||
| return Result; | |||
| } | |||
|
|
|||
| // TODO fix the override types | |||
There was a problem hiding this comment.
something about these overrides isn't quite right
export function createBranchComponent<T extends object, P extends {children?: any}, E extends Element>(type: string, render: (props: P, ref: ForwardedRef<E>) => ReactElement, useChildren?: (props: P) => ReactNode): (props: P & React.RefAttributes<T>) => ReactElement | null;
export function createBranchComponent<T extends object, P extends {children?: any}, E extends Element>(type: string, render: (props: P, ref: ForwardedRef<E>, node: Node<T>) => ReactElement, useChildren?: (props: P) => ReactNode): (props: P & React.RefAttributes<T>) => ReactElement | null;
export function createBranchComponent<T extends object, P extends object, E extends Element>(type: string, render: (props: P, ref: ForwardedRef<E>, node?: any) => ReactElement, useChildren: (props: P) => ReactNode = useCollectionChildren) {
They complain in TableView and some others that the Element type on the forwardedRef doesn't match (true, but I haven't figured out how to get the generic to work)
snowystinger
commented
Jan 21, 2025
| @@ -108,7 +108,7 @@ export const Section = /*#__PURE__*/ createBranchComponent('section', <T extends | |||
|
|
|||
| export interface CollectionBranchProps { | |||
| /** The collection of items to render. */ | |||
| collection: ICollection<Node<unknown>>, | |||
| collection?: ICollection<Node<unknown>>, | |||
There was a problem hiding this comment.
opinions on this change? It's kind of breaking as noted in Breadcrumbs
snowystinger
commented
Jan 21, 2025
| ); | ||
| } | ||
|
|
||
| // TODO: what should we do about TooltipTriggers with a single child that wraps the trigger and the tooltip? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6800, #7303
Request initially for Tooltips on Tabs, especially when we implement collapse behaviour if we want to go from a long label to icon only before collapsing further into a Picker. This has been requested in Issues before as well.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: